Skip to content

Fixes #31: add --wait global option to the install command #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2020
Merged

Fixes #31: add --wait global option to the install command #32

merged 1 commit into from
Mar 4, 2020

Conversation

aidun
Copy link
Contributor

@aidun aidun commented Mar 4, 2020 •
edited
Loading

This PR Fixes #31. Add the --wait global option to the install command, which was
accidentally removed in an older PR.

Signed-off-by: Markus Hartmann markush1986@gmail.com

Description

Add the --wait option which was deleted in an older PR:

Motivation and Context

Without this change the --wait option do not work.

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

go build
./arkade install openfaas --wait

--> in the logs is the helm command with --wait appended

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aidun
Fixes alexellis#31: add --wait global option to the install command
66db0ca 
Add the --wait global option to the install command, which was
accidentally removed in an older PR.

Signed-off-by: Markus Hartmann <markush1986@gmail.com>
@Waterdrips
Copy link
Contributor

Thanks @aidun , can you add Fixes #31 to your description, this will link the issue and PR and close that issue when this is merged.

Waterdrips
Waterdrips approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@Waterdrips Waterdrips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alexellis
alexellis approved these changes Mar 4, 2020
View reviewed changes
Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 4def417 into alexellis:master Mar 4, 2020
@alexellis
Copy link
Owner

I believe that this should have been added to each app, rather than here? What if an app ignores --wait?

@Waterdrips
Copy link
Contributor

This adds the flag definition, each app then decides what to do with that flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexellis alexellis alexellis approved these changes

+1 more reviewer

@Waterdrips Waterdrips Waterdrips approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] wait flag on install commands is missing
3 participants
@aidun @Waterdrips @alexellis