Remove libclang_rt.osx.a link workaround
#621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was fixing alexcrichton#279. All current usage of __builtin_available(...) in curl detects for APIs older than macOS 10.12, which is Rust's currently minimum supported version. This means that they are no-ops, and thus no longer emit a symbol that we need to link. Additionally, Rust's `std` has recently introduced these symbols in its standard library, see rust-lang/rust#138944. This means that even if curl _were_ to start using __builtin_available with a check for a newer macOS version, it would still successfully link (at least when using Rust 1.91.0 or newer). Finally, curl has supported the cfg option HAVE_BUILTIN_AVAILABLE for a while now, so if there ever does come a point where this starts having problems again, we can just disable that define.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously linked the Clang runtime
libclang_rt.osx.ato fix #279.All current usage of
__builtin_available(...)in curl detects for APIs older than macOS 10.12, which is Rust's currently minimum supported version. This means that they are no-ops, and thus no longer emit a symbol that we need to link.Additionally, Rust's
stdhas recently introduced these symbols in its standard library, see rust-lang/rust#138944. This means that even if curl were to start using__builtin_availablewith a check for a newer macOS version, it would still successfully link (at least when using Rust 1.91.0 or newer).Finally, curl has supported the cfg option
HAVE_BUILTIN_AVAILABLEfor a while now, so if there ever does come a point where this starts having problems again, we can just disable that define.Motivation: This makes cross-compiling from some other host to macOS slightly easier (since you no longer need to have the clang runtime built and available).