Preserve symlink mtimes #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrwats
commented
Apr 2, 2022
| @@ -792,6 +792,10 @@ fn unpack_links() { | |||
|
|
|||
| let md = t!(fs::symlink_metadata(td.path().join("lnk"))); | |||
| assert!(md.file_type().is_symlink()); | |||
|
|
|||
| let mtime = FileTime::from_last_modification_time(&md); | |||
| assert_eq!(mtime.unix_seconds(), 1448291033); | |||
There was a problem hiding this comment.
Previously this would have been "now"
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Aug 10, 2023
Summary: Update includes [alexcrichton/tar-rs#289], so we can unfork. [alexcrichton/tar-rs#289]: alexcrichton/tar-rs#289 Reviewed By: diliop, shayne-fletcher Differential Revision: D48230634 fbshipit-source-id: 2c3ff2ff01c8857f3f4e2e06b2688f739bcedb2c
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Aug 10, 2023
Summary: Update includes [alexcrichton/tar-rs#289], so we can unfork. [alexcrichton/tar-rs#289]: alexcrichton/tar-rs#289 Reviewed By: diliop, shayne-fletcher Differential Revision: D48230634 fbshipit-source-id: 2c3ff2ff01c8857f3f4e2e06b2688f739bcedb2c
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Aug 10, 2023
Summary: Update includes [alexcrichton/tar-rs#289], so we can unfork. [alexcrichton/tar-rs#289]: alexcrichton/tar-rs#289 Reviewed By: diliop, shayne-fletcher Differential Revision: D48230634 fbshipit-source-id: 2c3ff2ff01c8857f3f4e2e06b2688f739bcedb2c
facebook-github-bot
pushed a commit
to facebookincubator/below
that referenced
this pull request
Aug 10, 2023
Summary: Update includes [alexcrichton/tar-rs#289], so we can unfork. [alexcrichton/tar-rs#289]: alexcrichton/tar-rs#289 Reviewed By: diliop, shayne-fletcher Differential Revision: D48230634 fbshipit-source-id: 2c3ff2ff01c8857f3f4e2e06b2688f739bcedb2c
charliermarsh
added a commit
to astral-sh/tokio-tar
that referenced
this pull request
Feb 5, 2025
## Summary Ports alexcrichton/tar-rs#289 to `async-tar`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An archive with
preserve_mtime = trueshould match the behavior oftar -vpxf ...Addresses: #288