archive: allow preserving ownerships when unpacking #276
Conversation
| // it's not possible to unpack tar while preserving ownership | ||
| // without root permissions | ||
| assert!(ar.unpack(td.path()).is_err()); | ||
| } |
There was a problem hiding this comment.
AFAIK this is unlikely to ever get executed, even in CI, so could a test be written that runs in normal user mode as well?
There was a problem hiding this comment.
AFAIK this is unlikely to ever get executed, even in CI, so could a test be written that runs in normal user mode as well?
I think it would be very difficult. chown itself is a privileged operation, even on Windows. So it would be not possible to test it properly using normal user permissions.
Although, there might be a way to change gid on a file that is currently owned by the current effective user (file uid == user euid). But this kind of test would not cover the uid change, so it would be very difficult if not impossible to thoroughly test this functionality under a normal user account.
There was a problem hiding this comment.
If that is the situation can you arrange for the test to happen with sudo on CI?
Also ideally tthis wouldn't check in a *.tar file but build it up here so the tar file can be easily changed as well.
| // it's not possible to unpack tar while preserving ownership | ||
| // without root permissions | ||
| assert!(ar.unpack(td.path()).is_err()); | ||
| } |
There was a problem hiding this comment.
If that is the situation can you arrange for the test to happen with sudo on CI?
Also ideally tthis wouldn't check in a *.tar file but build it up here so the tar file can be easily changed as well.
e695234 to
2dabf8b
Compare
... also deleted ownership.tar in the tests
Added support for unpacking files while preserving numeric ownership IDs on Unix, this is useful when you want to make a backup utility since ownerships are very important on Unix-like systems. (Also useful if you want to make a system installer, the underlying idea is the same.)
Currently, operations are only available on Unix.
On Windows, it's also possible to set user ownerships, however, it's a very different system and does not use numeric IDs AFAIK. Any other suggestions on the current implementations are welcome!