-
-
Notifications
You must be signed in to change notification settings - Fork 54
feat(i18n): Add Spanish (es-MX) translation #145 #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): Add Spanish (es-MX) translation #145 #157
Conversation
…lization (es-MX) for the application's UI.
README_es.md
Outdated
@@ -0,0 +1,65 @@ | |||
<h1>Pororoca <img style="margin: 4px 0 0 4px" height="32" src="pororoca.png" alt="Pororoca Logo"/></h1> | |||
|
|||
Read in: [português](README_pt.md) | [русском](README_ru.md) | [italiano](README_it.md) | [中文](README_zh-cn.md) | [Deutsch](README_de.md) | [español](README_es.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot english, no need for spanish link in this file :-)
README_es.md
Outdated
## Características | ||
|
||
* Soporte para [HTTP/2](https://http2.github.io/) y [HTTP/3](https://developers.cloudflare.com/http3/). | ||
* Entornos a nivel de Colección. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lower-case Colección
|
||
LangString UserCollectionsAndPreferencesWereNotDeleted ${LANG_ENGLISH} "Your collections and preferences will not be deleted. They are located at: 'Users\you\AppData\Roaming\Pororoca\PororocaUserData\'." | ||
LangString UserCollectionsAndPreferencesWereNotDeleted ${LANG_PORTUGUESEBR} "Suas coleções e preferências não serão excluídas. Elas estão em: 'Users\você\AppData\Roaming\Pororoca\PororocaUserData\'." | ||
LangString UserCollectionsAndPreferencesWereNotDeleted ${LANG_ITALIAN} "Le tue collezione e preferenze non verranno eliminate. Si trovano in: 'Utenti\tu\AppData\Roaming\Pororoca\PororocaUserData\'." | ||
LangString UserCollectionsAndPreferencesWereNotDeleted ${LANG_RUSSIAN} "Ваши коллекции и предпочтения не будут удалены. Они находятся по адресу: 'Users\ты\AppData\Roaming\Pororoca\PororocaUserData\'." | ||
LangString UserCollectionsAndPreferencesWereNotDeleted ${LANG_SPANISH} "Tus colecciones y preferencias no se eliminarán. Se encuentran en: 'Users\you\AppData\Roaming\Pororoca\PororocaUserData\'." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usted (o tú)
Users\you\AppData\
@@ -33,6 +33,7 @@ Language.German or | |||
|
|||
Language.English or | |||
Language.SimplifiedChinese or | |||
Language.Spanish or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've searched online and looks like most Spanish-speaking countries (South America, Spain and Cuba) use comma instead of dot for decimal separator.
https://pt.wikipedia.org/wiki/Separador_decimal
We need to specify this because Pororoca uses InvariantGlobalization to reduce program size, so the default configuration is English, which uses dot.
Maybe we can reconsider InvariantGlobalization in the future and use the decimal separator provided by the operating system, but for now, I would suggest using comma decimal separator for Spanish.
"HttpRepeater/InputDataFileSrcPathWatermark": "(ruta de archivo src)", | ||
"HttpRepeater/InputDataTypeFile": "Archivo", | ||
"HttpRepeater/InputDataTypeRaw": "Raw JSON array", | ||
"HttpRepeater/InputDataTypeRawComment": "los comentarios están permitidos", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here it would be better:
"se permiten comentarios"
"TopMenuOptions/EnableTlsVerification": "Activar verificación TLS", | ||
"TopMenuOptions/Language": "Idioma", | ||
"TopMenuOptions/Theme": "Tema", | ||
"TopMenuTheme/AmazonianNight": "Amazonian night", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can translate the theme names too :-)
This pull request adds full support for Spanish (es-MX) localization to the Pororoca application.
Changes included:
Spanish
to the language enum and extensions.es-MX.json
file with translated strings..csproj
."TopMenuLanguage/Spanish"
key ini18n_keys.json
and added translations to other languages.TimeTextFormatter
for the new culture.All steps from the translation tutorial were followed as outlined in the documentation:
https://github.com/alexandrehtrb/Pororoca/blob/main/docs/tutorials/how-to-translate.md
Let me know if any adjustment or formatting is needed. Thanks for the opportunity to contribute!