Skip to content

Conversation

marcoPacheco1
Copy link
Contributor

This pull request adds full support for Spanish (es-MX) localization to the Pororoca application.

Changes included:

  • Added Spanish to the language enum and extensions.
  • Created es-MX.json file with translated strings.
  • Referenced the new JSON file in the .csproj.
  • Inserted the "TopMenuLanguage/Spanish" key in i18n_keys.json and added translations to other languages.
  • Updated the top menu (XAML and ViewModel) to include the Spanish option.
  • Defined the decimal separator in TimeTextFormatter for the new culture.
  • Added a localized README file for Spanish.
  • Spanish support was also added to the Windows installer.

All steps from the translation tutorial were followed as outlined in the documentation:
https://github.com/alexandrehtrb/Pororoca/blob/main/docs/tutorials/how-to-translate.md

Let me know if any adjustment or formatting is needed. Thanks for the opportunity to contribute!

README_es.md Outdated
@@ -0,0 +1,65 @@
<h1>Pororoca <img style="margin: 4px 0 0 4px" height="32" src="pororoca.png" alt="Pororoca Logo"/></h1>

Read in: [português](README_pt.md) | [русском](README_ru.md) | [italiano](README_it.md) | [中文](README_zh-cn.md) | [Deutsch](README_de.md) | [español](README_es.md)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot english, no need for spanish link in this file :-)

README_es.md Outdated
## Características

* Soporte para [HTTP/2](https://http2.github.io/) y [HTTP/3](https://developers.cloudflare.com/http3/).
* Entornos a nivel de Colección.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lower-case Colección


LangString UserCollectionsAndPreferencesWereNotDeleted ${LANG_ENGLISH} "Your collections and preferences will not be deleted. They are located at: 'Users\you\AppData\Roaming\Pororoca\PororocaUserData\'."
LangString UserCollectionsAndPreferencesWereNotDeleted ${LANG_PORTUGUESEBR} "Suas coleções e preferências não serão excluídas. Elas estão em: 'Users\você\AppData\Roaming\Pororoca\PororocaUserData\'."
LangString UserCollectionsAndPreferencesWereNotDeleted ${LANG_ITALIAN} "Le tue collezione e preferenze non verranno eliminate. Si trovano in: 'Utenti\tu\AppData\Roaming\Pororoca\PororocaUserData\'."
LangString UserCollectionsAndPreferencesWereNotDeleted ${LANG_RUSSIAN} "Ваши коллекции и предпочтения не будут удалены. Они находятся по адресу: 'Users\ты\AppData\Roaming\Pororoca\PororocaUserData\'."
LangString UserCollectionsAndPreferencesWereNotDeleted ${LANG_SPANISH} "Tus colecciones y preferencias no se eliminarán. Se encuentran en: 'Users\you\AppData\Roaming\Pororoca\PororocaUserData\'."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usted (o tú)
Users\you\AppData\

@@ -33,6 +33,7 @@ Language.German or

Language.English or
Language.SimplifiedChinese or
Language.Spanish or
Copy link
Owner

@alexandrehtrb alexandrehtrb Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've searched online and looks like most Spanish-speaking countries (South America, Spain and Cuba) use comma instead of dot for decimal separator.

https://pt.wikipedia.org/wiki/Separador_decimal

We need to specify this because Pororoca uses InvariantGlobalization to reduce program size, so the default configuration is English, which uses dot.

Maybe we can reconsider InvariantGlobalization in the future and use the decimal separator provided by the operating system, but for now, I would suggest using comma decimal separator for Spanish.

"HttpRepeater/InputDataFileSrcPathWatermark": "(ruta de archivo src)",
"HttpRepeater/InputDataTypeFile": "Archivo",
"HttpRepeater/InputDataTypeRaw": "Raw JSON array",
"HttpRepeater/InputDataTypeRawComment": "los comentarios están permitidos",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here it would be better:

"se permiten comentarios"

"TopMenuOptions/EnableTlsVerification": "Activar verificación TLS",
"TopMenuOptions/Language": "Idioma",
"TopMenuOptions/Theme": "Tema",
"TopMenuTheme/AmazonianNight": "Amazonian night",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can translate the theme names too :-)

@alexandrehtrb alexandrehtrb merged commit 40e82c8 into alexandrehtrb:develop Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants