Save all WebSocket response messages to files (#60) #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: save all WebSocket response messages to files (alexandrehtrb#60)
alexandrehtrb
requested changes
Jul 7, 2025
src/Pororoca.Desktop/ViewModels/WebSocketConnectionViewModel.cs
Outdated
Show resolved
Hide resolved
src/Pororoca.Desktop/ViewModels/WebSocketConnectionViewModel.cs
Outdated
Show resolved
Hide resolved
src/Pororoca.Desktop/ViewModels/WebSocketConnectionViewModel.cs
Outdated
Show resolved
Hide resolved
src/Pororoca.Desktop/ViewModels/WebSocketConnectionViewModel.cs
Outdated
Show resolved
Hide resolved
- Update IsSaveAllExchangedMessagesToFilesVisible to check if any exchanged message can be saved, ensuring the button is visible as long as at least one message is savable. - Change SaveAllExchangedMessagesToFilesAsync to save messages in the order they appear in the collection, not in reverse.
Fix save-all-messages button visibility and save order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the feature described in issue [#60]