Fix TextEditor on HTTP request page not being completely visible #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is run on construction and the editor document will always be null here.
…ntrols The negative margins were causing the editor control to be cut off, this makes sure the entire control is visible.
The text editor control seems to reserve width for the vertical scrollbar and then dynamically increase the width of the control before actually displaying the scrollbar. This forces the control to always take the available width.
|
Hello! Welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the text editor for the content or response of an HTTP request was not cut-off at the right edge. After some investigation this seems to be due to the negative margins of the parent grid, adding positive margins to the text editor fixed this.
However, the control would then not take up the entire available width and dynamically expanded before actually showing the scrollbar. I fixed this by force setting the text editor width to the bounds width, whenever the bounds changed. I am not very familiar with Avalonia, so there might be a better way to do this.
Let me know if you want me to drop the first commit or make a separate PR for it as it is unrelated to the rest of this PR. It avoids a (caught) exception in InstallTextMate due to the editor document always being null at construction.
This fixes #101.