Make Parser::peek_tag public
#532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a direct test for |
9fa0e95 to
d6ce820
Compare
done! |
|
|
d6ce820 to
b73944b
Compare
Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
b73944b to
c1e5c78
Compare
alex
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the API in dynamic contexts (similarly to #531), some field types can be difficult to read when the type information is not known at compile time.
For example,
Choiceparsing requires the choice types to be known at compile time. By makingParser::peek_tagpublic, a user can check if the upcoming tag matches any of the expected Choice types, and call the appropriate method to parse it.cc @woodruffw