impl hash for several string types #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request implements the Hash trait for several ASN.1 string types. It updates the derive macros on PrintableString, Utf8String, BMPString, and UniversalString in src/types.rs and updates the README documentation to reflect these changes.
- Added #[derive(Hash)] to PrintableString, Utf8String, BMPString, and UniversalString.
- Updated README.md to document the new Hash implementation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/types.rs | Added Hash derive for string types to support hashing needs. |
| README.md | Updated documentation to note the Hash support. |
Comments suppressed due to low confidence (1)
src/types.rs:266
- Consider adding unit tests to ensure that the derived Hash implementations for PrintableString, Utf8String, BMPString, and UniversalString behave as expected and produce consistent hash values.
#[derive(Clone, Debug, PartialEq, Eq, Hash)]
reaperhulk
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.