Skip to content

Conversation

chenrui333
Copy link
Contributor

right now the shell completions are set as 755 rather than 644, update the install step (build.rs outs the right completion scripts)

Signed-off-by: Rui Chen <rui@chenrui.dev>
@alerque
Copy link
Owner

alerque commented Dec 24, 2024

Sure this is a reasonable fix, but also it shouldn't have mattered. This is not the permissions they get installed with, only the intermediary location so autotools could find and install them to the final system location (which happens with the correct permissions). I'll merge this, but please see also my comment no the Homebrew PR because the completions and man page should have been installed already with make install and it would be nice to fix this properly so that works (also these macros are used on dozens of other projects now, so it would be well to figure out what's actually wrong).

@chenrui333
Copy link
Contributor Author

@alerque i think you are right, it is just intermediary step thing, I am gonna revert the manual installation steps on the homebrew side.

@alerque alerque merged commit 36c7c3a into alerque:master Dec 25, 2024
@alerque
Copy link
Owner

alerque commented Dec 25, 2024

Thanks again for the fix. However much it doesn't affect the final output there is no good reason to have execute permission set on the intermediary files. I've also cherry picked this commit of yours your into half a dozen other projects so far, with a few more to come when I get a chance. Thanks for contributing.

Also see my rant about language vs. project oriented build systems in the HB review comments, but it's not actionable, just a rant ;-)

I'm kind of curious how you ran into this in the first place? Were you just combing through Rust project formulas looking for completions assuming if they were not done manually they were not done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants