constify: Remove extra new line when version is printed, optimize Makefile as well #189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
Some small improvements for
constify
. I slighty optimized theMakefile
and remove useless new lines inconstify.c
when printing version.In this optimized version, I made the following improvements:
CFLAGS
andDEFINES
variables:=
instead of=
for variable assignment to prevent unnecessary re-evaluation.$(shell date +%Y%m%d)
instead of invoking the date command multiple times.LIBS
flag into anifeq
block for better readability$@
and$<
in recipe commands to handle filenames with spaces (maybe useful for Windows target)For the
constify.c
source file, I just removed the\n\n
for thePrintVersion
function.