Skip to content

correct lexing AS keyword for docker #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2025

Conversation

panekj
Copy link
Contributor

@panekj panekj commented Jul 27, 2025

btw. tinygo can be replace with just go

cmd/chromad/static/wasm_exec.js: $(shell go env GOROOT)/lib/wasm/wasm_exec.js
	install -m644 $< $@

cmd/chromad/static/chroma.wasm: cmd/libchromawasm/main.go
	GOOS=js GOARCH=wasm go build -o $@ $<

@alecthomas alecthomas merged commit 1ca24c9 into alecthomas:master Jul 27, 2025
@alecthomas
Copy link
Owner

alecthomas commented Jul 27, 2025

Go produces much larger .wasm files. For local dev I'd like to be able to fallback to using the server though.

@panekj
Copy link
Contributor Author

panekj commented Jul 28, 2025

For local dev I'd like to be anle to fallback to using the server though.

I don't understand, libchromawasm/wasm_exec.js has to be built and copied to chromad/static to be used no? Or is there some other server?

@panekj panekj deleted the pj/fix/AS-keyword branch July 28, 2025 00:03
@alecthomas
Copy link
Owner

There are two render paths - one via WASM running on the client, and one via server-side endpoints. During local dev it would be nice if one didn't need to constantly recompile the WASM binary in order to use the playground locally, but I just haven't implemented that fallback correctly yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants