feat(formatter): add writeCSSComments option #1112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
reviewed
Jul 25, 2025
formatters/html/html.go
Outdated
| @@ -419,26 +424,47 @@ func (f *Formatter) tabWidthStyle() string { | |||
| // WriteCSS writes CSS style definitions (without any surrounding HTML). | |||
| func (f *Formatter) WriteCSS(w io.Writer, style *chroma.Style) error { | |||
| css := f.styleCache.get(style, false) | |||
|
|
|||
| // Helper to write a CSS rule if styles is non-empty | |||
| writeRule := func(comment string, selector string, styles string) error { | |||
|
I'm honestly no sure why .bg is global, it seems likely that it was just an omission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when writing the css file comments before each class is present.
(Also why is there a .bg class, feels like that could collide)
This is probably a micro-optimization but felt like the comments didn't serve any purpose except clarity and debug value.
Also skipped writing empty css classes.
Before and after writing css file for style "catppuccin-mocha"
> ls -l -B .rw-r--r-- 4,934 jocke 25 Jul 01:51 with.css .rw-r--r-- 3,337 jocke 25 Jul 01:50 without.cssI didn't wanna make any changes to the output without changes to the options.
Maybe we could just remove the comments all together and skip this extra logic.