Add MoonScript lexer #1091
Merged
Add MoonScript lexer #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with: Package Version -------- ------- pip 25.0.1 Pygments 2.19.1 pystache 0.6.8
...in the generated MoonScript lexer. The regex2 library only handles the Python-style capture group `?P<name>` if a flag is set and it doesn't handle the Python-style named back reference `?P=<name>` at all. Replace '?P<name>' with .NET-style '?<name>' and '?P=<name>' with ECMAScript-style '\k<name>', which regex2 parses
...because they are also listed under OperatorWord rule
Comment on lines
+53
to
+81
| <state name="ws"> | ||
| <rule pattern="(?:--\[(?<level>=*)\[[\w\W]*?\](\k<level>)\])"><token type="CommentMultiline"/></rule> | ||
| <rule pattern="(?:--.*$)"><token type="CommentSingle"/></rule> | ||
| <rule pattern="(?:\s+)"><token type="TextWhitespace"/></rule> | ||
| </state> | ||
| <state name="varname"> | ||
| <rule><include state="ws"/></rule> | ||
| <rule pattern="\.\."><token type="Operator"/><pop depth="1"/></rule> | ||
| <rule pattern="[.:]"><token type="Punctuation"/></rule> | ||
| <rule pattern="(?:[^\W\d]\w*)(?=(?:(?:--\[(?<level>=*)\[[\w\W]*?\](\k<level>)\])|(?:--.*$)|(?:\s+))*[.:])"><token type="NameProperty"/></rule> | ||
| <rule pattern="(?:[^\W\d]\w*)(?=(?:(?:--\[(?<level>=*)\[[\w\W]*?\](\k<level>)\])|(?:--.*$)|(?:\s+))*\()"><token type="NameFunction"/><pop depth="1"/></rule> | ||
| <rule pattern="(?:[^\W\d]\w*)"><token type="NameProperty"/><pop depth="1"/></rule> | ||
| </state> | ||
| <state name="funcname"> | ||
| <rule><include state="ws"/></rule> | ||
| <rule pattern="[.:]"><token type="Punctuation"/></rule> | ||
| <rule pattern="(?:[^\W\d]\w*)(?=(?:(?:--\[(?<level>=*)\[[\w\W]*?\](\k<level>)\])|(?:--.*$)|(?:\s+))*[.:])"><token type="NameClass"/></rule> | ||
| <rule pattern="(?:[^\W\d]\w*)"><token type="NameFunction"/><pop depth="1"/></rule> | ||
| <rule pattern="\("><token type="Punctuation"/><pop depth="1"/></rule> | ||
| </state> | ||
| <state name="goto"> | ||
| <rule><include state="ws"/></rule> | ||
| <rule pattern="(?:[^\W\d]\w*)"><token type="NameLabel"/><pop depth="1"/></rule> | ||
| </state> | ||
| <state name="label"> | ||
| <rule><include state="ws"/></rule> | ||
| <rule pattern="::"><token type="Punctuation"/><pop depth="1"/></rule> | ||
| <rule pattern="(?:[^\W\d]\w*)"><token type="NameLabel"/></rule> | ||
| </state> |
There was a problem hiding this comment.
MoonScript inherits these from the Lua lexer, but I don't think MoonScript uses them. I know MS doesn't use goto or label or multi-line comments, and I don't actually see any way for these states to be reached. I think they can be safely removed. The tests still pass if these lines are deleted because I didn't see any way to test them.
alecthomas
approved these changes
Jun 20, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change...
pygments2chroma_xml.pyscript using Pygments version 2.19.1rexexp2-incompatible Python-style patterns with compatible ones:?P<name>with .NET-style?<name>?P=namewith ECMAScript-style\k<name>and,or, andnotfrom the Keyword rule, since they are also listed under the OperatorWord rule