fix: properly tokenizes default_tags attribute #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was playing with this further with The before, you can see The after |
|
Seems like an improvement, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version
default_tagswas getting processed like{"type":"NameAttribute","value":"default"}, {"type":"Error","value":"_"}, {"type":"NameOther","value":"tags"}but
default_tagsis a valid attribute or parameter here and doesn't need parsed as such. This matchesdefault_tagsproperlyHere is the before
And the after with this change
Hopefully I did this correctly. I fixed #988 but it's been a minute. Thanks!