Misc fixes #499
Merged
Misc fixes #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method rather should use mpfr_set_q with MPFR_RNDN to reproduce numbers.Rational.__float__(). Closes aleaxit#498
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #499 +/- ##
==========================================
+ Coverage 85.52% 85.60% +0.07%
==========================================
Files 50 50
Lines 11656 11650 -6
Branches 2202 2201 -1
==========================================
+ Hits 9969 9973 +4
+ Misses 1687 1677 -10 ☔ View full report in Codecov by Sentry. |
|
Thanks for all the clean-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpfr.__floor__,__ceil__and__trunc__, closes Expected behavior of math.ceil, math.floor, math.trunc, and round #143mpq.__float__(), closes Invalid mpq.__float__? #498I'll mark also additional issues (merging this will close them too):