Skip to content

Conversation

albertocavalcante
Copy link
Owner

@albertocavalcante albertocavalcante commented Mar 21, 2025

Warning

AI Generated

PR: Comprehensive Build System & Dependency Upgrade

This PR includes several significant improvements to our build system, development environment, and dependencies.

Dependency Upgrades

  • Go Version: Upgraded from 1.22.5 to 1.23.7
  • Client Libraries: Updated jfrog-client-go to v1.51.1
  • Bazel Tooling:
    • Upgraded rules_go and gazelle dependencies
    • Added aspect_bazel_lib for enhanced Bazel capabilities
    • Updated WORKSPACE lockFileVersion from 12 to 18
  • Security & Performance: Upgraded numerous dependencies including crypto libraries, compression tools, and networking components

Build System Enhancements

  • Static Analysis: Implemented comprehensive nogo configuration
    • Created modular analyzer structure with standard and extended analyzers
    • Added config.json with appropriate exclusions for third-party code
  • Build Correctness: Added correctness.bazelrc with settings for:
    • Remote cache uploads
    • Network access controls
    • Test timeout warnings
    • Directory source tracking
    • Environment variable inheritance
    • Python package initialization
  • Pure Go Builds: Changed go_binary targets to use pure = "on" for better portability

Development Environment Improvements

  • Container Configuration: Enhanced Dockerfile and devcontainer setup
    • Added "Garf RHEL" configuration in devcontainer.json
    • Installed essential development tools (bazelisk, starpls, buildifier, buildozer)
  • IDE Integration: Improved VSCode configuration
    • Added Bazel query settings
    • Enhanced code flow analysis
    • Configured automatic build updates
    • Added "Build Garf" task

Code Organization

  • Project Structure: Added BUILD.bazel files to pkg and tools directories
  • Bazel Modules: Structured nogo tools as a separate module with precise dependencies
  • Documentation: Added instructions for regenerating bazelrc presets

Functional Improvements

  • Error Handling: Enhanced UploadGenericArtifact function in JFrogClient to better handle failures

This PR represents a significant improvement in our build system's robustness, development experience, and dependency management while ensuring we stay current with the latest Go toolchain.

@albertocavalcante albertocavalcante changed the title Project update garf: refactor nogo, upgrade jfrog-client, do not use cgo, fix circl issue Mar 21, 2025
@albertocavalcante albertocavalcante merged commit dc58c84 into main Mar 25, 2025
3 checks passed
@albertocavalcante albertocavalcante deleted the project-update branch March 25, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant