That sounds great! Here's the feedback I got in IRC about the best way to do this:

13:28 <jwilm> I'd like to handle errors in Alacritty's config deserializer by substituting default values or simply omitting failed entries that are part of a sequence. Is https://serde.rs/ignored-any.html the best example of how to achieve this sort of thing?
14:04 <dtolnay> rovar: the serde(skip) not doing anything is a bug but that should work eventually https://github.com/serde-rs/serde/issues/1048
14:04 <dtolnay> rovar: for now i think the impl you wrote is the best way
14:04 <dtolnay> jwilm: IgnoredAny will not let you omit failing entries in a sequence
14:05 <dtolnay> jwilm: you only get to deserialize each entry once, so you cannot try to deserialize it to T, see that it failed, and deserialize it instead to IgnoredAny
14:05 <dtolnay> jwilm: i would suggest deserializing each sequence entry to serde_yaml::Value which always succeeds as long as the yaml is syntactically fine
14:05 <dtolnay> jwilm: then try to deserialize the Value to a T

fyi @dtolnay added your comments here

Broken config files should not cause Alacritty not to launch #954

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions