Skip to content

5.0.0 Warning: ReactConfetti: getSnapshotBeforeUpdate() should be used with componentDidUpdate(). #73

@wheeler

Description

@wheeler

😞 Well looks like I didn't test enough. When using 5.0.0 in my project I get...

Warning: ReactConfetti: getSnapshotBeforeUpdate() should be used with componentDidUpdate(). This component defines getSnapshotBeforeUpdate() only.

I can look in to fixing (probably just changing the functionality from getSnapshotBeforeUpdate to componentDidUpdate).

@alampros FYI. It's only a warning so probably not worth looking in to unpublishing 5.0.0. It could be asserted "it works but gives warnings that will be fixed in 5.0.1". The minor bummer might be that if the solution doesn't require 16.3 the 5.0.0 breaking change bump would have been unnecessary.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions