Skip to content

Conversation

xiki-tempula
Copy link
Collaborator

Fix #295

@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Merging #325 (442d31b) into master (4c3308c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   98.75%   98.76%           
=======================================
  Files          27       27           
  Lines        1767     1775    +8     
  Branches      389      389           
=======================================
+ Hits         1745     1753    +8     
  Misses          2        2           
  Partials       20       20           
Impacted Files Coverage Δ
src/alchemlyb/preprocessing/subsampling.py 100.00% <100.00%> (ø)

@xiki-tempula xiki-tempula requested a review from orbeckst June 11, 2023 10:36
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Maybe I would log at INFO but we can always increase the level later.

@orbeckst orbeckst merged commit 1ff15fe into master Jun 12, 2023
@orbeckst orbeckst deleted the 295-the-output-of-the-function-statistical_inefficiency-doesnt-include-statistical-inefficiency-value branch June 12, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The output of the function statistical_inefficiency doesn't include statistical inefficiency value
2 participants