309 make pip test work in m1 mac #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 26 26
Lines 1749 1749
Branches 380 380
=======================================
Hits 1727 1727
Misses 2 2
Partials 20 20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
orbeckst
approved these changes
Apr 7, 2023
|
please squash-merge yourself when ready, @xiki-tempula |
|
@orbeckst Sorry I guess I haven't tried other machines. I haven't tried other machines but it hangs on my M1 Mac. As is said in #309. If I pip install the source it works fine. It only hangs when I upload it to pypi and download it to install. I said it is M1 Mac as I got some other issue happening with M1 Mac in other packages so I suspect it is a M1 Mac issue. |
orbeckst
pushed a commit
that referenced
this pull request
Apr 17, 2023
- fix #311 - In PR #310 (v2.0.1) we changed the behavior of the dir kwarg in ABFE: glob patterns are now part of the prefix kwar. This API change should not have been included in a patch release but because it came very soon after 2.0.0, we kept it. This PR explicitly issues a warning when a glob pattern is used so that subsequent failures (ValueError) are easier to understand. - add warning if glob pattern `*` is used in `dir` - add test - updated docs - update CHANGES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, I got it to work now by changing
glob.globtoPath.glob, these two should be the same butPath.globworks fine.I tried
pip install -i https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple alchemlyb=="2.0.1"
and then
pytest --pyargs alchemlyb
Where all tests passed fine.