Inefficient implementation of undo/redo #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todo: * probably should limit number of undos/redos * There is probably a way to reduce special code to make sure things are copied and not just reference-shared...vala...
Alecaddd
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Great initial implementation!
The only issue is that the app crashes if I create a new item after an undo action. This is due to the layers item not updating properly at every history interaction and freaking out when trying to update the list.
I'll deal with it in a follow up PR, I'm okay with merging this.
Comment on lines
-64
to
+59
| construct { | ||
| public Model () { |
There was a problem hiding this comment.
I'm wondering if there's a particular reason why you converted this from a construct creation to a class creation. The construct always runs before any class with argument is called, so there's not need to call this().
Did you stumble upon any issue with it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary / How this PR fixes the problem?
Implement basic undo/redo. code is somewhat inefficient...but honestly fairly ok considering other limitations currently in the software. I don't guarantee this is bug-free ;)
Steps to Test
Undo with ctrl-z, redo with ctrl-shift-z
Known Issues / Things To Do
Todo:
things are copied and not just reference-shared...vala...