Selection alignment #675
Merged
Selection alignment #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alecaddd
approved these changes
Dec 4, 2021
src/Services/ActionManager.vala
Outdated
Comment on lines
174
to
179
| typing_accelerators.set (ACTION_ALIGN_LEFT, "<Control>3"); | ||
| typing_accelerators.set (ACTION_ALIGN_HCENTER, "<Control>4"); | ||
| typing_accelerators.set (ACTION_ALIGN_RIGHT, "<Control>5"); | ||
| typing_accelerators.set (ACTION_ALIGN_TOP, "<Control>6"); | ||
| typing_accelerators.set (ACTION_ALIGN_VCENTER, "<Control>7"); | ||
| typing_accelerators.set (ACTION_ALIGN_BOTTOM, "<Control>8"); |
There was a problem hiding this comment.
Little nit: I'd prefer these to use the Alt modifier, and start from 1 to 6.
The Ctrl + number modifier should be reserved for quick zooms (eg. zoom to fit, zoom to item, etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary / How this PR fixes the problem?
Implements automatic alignment of objects.
Steps to Test
Use Ctrl-3 through Ctrl-8 to test the different alignments.
Screenshots
Known Issues / Things To Do
It probably isn't 100% correct in its behavior, but it is a start.