Skip to content

Filter candidates and specialize artboard snaps #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mbfraga
Copy link
Collaborator

@mbfraga mbfraga commented Mar 7, 2021

Summary / How this PR fixes the problem?

Candidates are now filtered with regards to artboards.

Properly generate artboard snaps.

Steps to Test

  • Moving items inside of an artboard should snap to the artboard snaps and to any other items inside the artboard
  • Moving rectangles not in an artboard should not snap to objects inside of an artboard

This PR fixes/implements the following bugs/features:

  • Canvas items will not include artboard contents as candidates.
  • Artboard items will only include contents as candidates.

Candidates are now filtered with regards to artboards.
   * Canvas items will not include artboard contents as candidates.
   * Artboard items will only include contents as candidates.

Properly generate artboard snaps.
@mbfraga mbfraga force-pushed the wip/mbfraga/small_snapping_improvements branch from c92ee00 to e8c1857 Compare March 8, 2021 00:50
@mbfraga mbfraga force-pushed the wip/mbfraga/small_snapping_improvements branch from f8ee1f3 to d0fde9d Compare March 8, 2021 01:25
@Alecaddd Alecaddd self-requested a review March 8, 2021 02:25
@Alecaddd Alecaddd merged commit d0fde9d into akiraux:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants