Skip to content

Handle multiple colors #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 5, 2021
Merged

Handle multiple colors #505

merged 14 commits into from
Mar 5, 2021

Conversation

Alecaddd
Copy link
Member

@Alecaddd Alecaddd commented Mar 3, 2021

Summary / How this PR fixes the problem?

Implement the alpha mixing of multiple fill and border colors.

Steps to Test

  • Create a shape
  • Add multiple colors and fills
  • Play with the alpha of the extra colors

Screenshots

color-blending

Known Issues / Things To Do

The color gets reset once the item is selected, which doesn't make sense. Fixed!
For now we only handle 1 border size, so we get the bigger and go with it.
In the future we will probably implement child items just to handle different border sizes and also different offset once implemented in goocanvas.

This PR fixes/implements the following bugs/features:

  • Blend colors by their alpha channel for fills and borders.
  • Use the color picker icon for the color picker button.
  • Move the color picker close to the color button and style them to make them related.

@Alecaddd Alecaddd requested review from giacomoalbe and albfan and removed request for giacomoalbe March 4, 2021 05:30
@Alecaddd Alecaddd added this to the v0.1.0 milestone Mar 4, 2021
@Alecaddd Alecaddd requested a review from giacomoalbe March 4, 2021 05:31
@Alecaddd Alecaddd marked this pull request as ready for review March 4, 2021 05:31
@Alecaddd Alecaddd mentioned this pull request Mar 4, 2021
46 tasks
@Alecaddd Alecaddd requested review from mbfraga and removed request for albfan and giacomoalbe March 5, 2021 01:37
@Alecaddd
Copy link
Member Author

Alecaddd commented Mar 5, 2021

Pinging @mbfraga to see if he has time to test this.

mbfraga
mbfraga previously approved these changes Mar 5, 2021
@Alecaddd Alecaddd merged commit 288e02c into master Mar 5, 2021
@Alecaddd Alecaddd deleted the handle-multiple-colors branch March 5, 2021 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants