Automatic passivation for sharding #3718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismaelhamed
commented
Feb 8, 2019
| settings, | ||
| _extractEntityId, | ||
| _extractShard, | ||
| new LeastShardAllocationStrategy(10, 3), |
There was a problem hiding this comment.
ClusterSharding.DefaultShardAllocationStrategy() seems to be accessible from here in the JVM (see #L69)
ismaelhamed
commented
Feb 8, 2019
| @@ -617,14 +624,28 @@ internal static class Shards | |||
| } | |||
| } | |||
|
|
|||
| public static void PassivateCompleted<TShard>(this TShard shard, Shard.EntityStopped evt) where TShard: IShard | |||
| private static void PassivateIdleEntities<TShard>(this TShard shard) where TShard : IShard | |||
There was a problem hiding this comment.
My first implementation was easier to the eye and more in line with the JVM, but probably less performant:
var deadline = DateTime.Now.Ticks - shard.Settings.PassivateIdleEntityAfter.Ticks;
var refsToPassivate = shard.LastMessageTimestamp.Where(s => s.Value < deadline).Select(s => shard.RefById[s.Key]).ToArray();
if (refsToPassivate.Any())
{
shard.Log.Debug($"Passivating [{refsToPassivate.Length}] idle entities");
refsToPassivate.ForEach(entity => Passivate(shard, entity, shard.HandOffStopMessage));
}08fe424 to
cdc4110
Compare
Horusiath
approved these changes
Feb 9, 2019
| @@ -617,14 +624,28 @@ internal static class Shards | |||
| } | |||
| } | |||
|
|
|||
| public static void PassivateCompleted<TShard>(this TShard shard, Shard.EntityStopped evt) where TShard: IShard | |||
| private static void PassivateIdleEntities<TShard>(this TShard shard) where TShard : IShard | |||
| @@ -660,26 +681,61 @@ internal static class Shards | |||
| } | |||
| else | |||
| { | |||
| if (shard.MessageBuffers.TryGetValue(id, out var buffer)) | |||
| // TODO | |||
There was a problem hiding this comment.
Nada. Missed this one before pushing...
cdc4110 to
fd03bd7
Compare
Aaronontheweb
approved these changes
Feb 10, 2019
|
LGTM |
This was referenced Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #25765