GetOrElse null handling fix #3575
Conversation
| @@ -144,7 +144,7 @@ public static string BetweenDoubleQuotes(this string self) | |||
| /// <returns>TBD</returns> | |||
| public static T GetOrElse<T>(this T obj, T elseValue) | |||
| { | |||
| if (obj.Equals(default(T))) | |||
| if (obj == null || obj.Equals(default(T))) | |||
There was a problem hiding this comment.
Maybe we should just remove that method and use ?? instead? Btw. this could cause strange behavior i.e. elseValue on 0.
There was a problem hiding this comment.
what kind of strange behavior you have on mind? With structs the first condition will never match since they cannot be null, so this will only change behavior for classes
There was a problem hiding this comment.
Given obj = 0:
if (obj == null || obj.Equals(default(T)))
if (0 == null || 0.Equals(default(int)))
if (false || 0.Equals(0))
if (false || true)
if (true)
What I mean here is that this method has no sense in context of value types, unlike null 0 is not an absence of value. This method was ported straightforward from scala for null checks way back in the past (before elvis operator existed AFAIK).
There was a problem hiding this comment.
right, I thought you were referencing to the change and you were talking about the method itself.
It's used only on few places so i can remove it completely and change the code where it's used if you want
There was a problem hiding this comment.
That would be great! 👍 Thanks for the patience.
455cba9 to
df61f97
Compare
fixes #3564