Skip to content

Conversation

Sam13
Copy link
Contributor

@Sam13 Sam13 commented Jun 29, 2018

As discussed in Gitter: Fixes bug in FileIO.FromFile that the same file can be opened multiple times at the same time

Copy link
Contributor

@marcpiechura marcpiechura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -201,6 +201,31 @@ public void FileSource_should_complete_only_when_all_contents_of_a_file_have_bee
}, _materializer);
}

[Fact]
public void FileSource_should_open_file_in_shared_mode_for_reading_multiple_times()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcpiechura
Copy link
Contributor

Thanks a lot @Sam13

@marcpiechura marcpiechura merged commit 98a1a12 into akkadotnet:dev Jun 29, 2018
@Aaronontheweb Aaronontheweb added this to the 1.3.9 milestone Jun 29, 2018
@Sam13 Sam13 deleted the fix-fileio-file-share-read branch February 25, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants