Added an UnboundStablePriorityMailbox #3536
Conversation
…priority. Messages with the same priority will be send using the same order as they appear. akkadotnet#2652 is the related issue.
| @@ -682,7 +682,7 @@ public override IMessageQueue Create(IActorRef owner, ActorSystem system) | |||
| /// Priority mailbox base class; unbounded mailbox that allows for prioritization of its contents. | |||
| /// Extend this class and implement the <see cref="PriorityGenerator"/> method with your own prioritization. | |||
| /// The value returned by the <see cref="PriorityGenerator"/> method will be used to order the message in the mailbox. | |||
| /// Lower values will be delivered first. Messages ordered by the same number will remain in delivery order. | |||
| /// Lower values will be delivered first. Messages ordered by the same number will remain in delivered in undefined order. | |||
| /// Priority mailbox - an unbounded mailbox that allows for prioritization of its contents. | ||
| /// Extend this class and implement the <see cref="PriorityGenerator"/> method with your own prioritization. | ||
| /// The value returned by the <see cref="PriorityGenerator"/> method will be used to order the message in the mailbox. | ||
| /// Lower values will be delivered first. Messages ordered by the same number will remain in delivery order. |
| /// <inheritdoc cref="MailboxType"/> | ||
| public sealed override IMessageQueue Create(IActorRef owner, ActorSystem system) | ||
| { | ||
| return new UnboundedStablePriorityMessageQueue(PriorityGenerator, InitialCapacity); |
| { | ||
| /// <summary> | ||
| /// Priority queue implemented using a simple list with binary search for inserts. | ||
| /// This specific implementation is cheap in terms of memory but weak in terms of performance. |
There was a problem hiding this comment.
Thanks for the comment, this is helpful.
|
I actually forgot I made this pull request. I will try to add unit tests asap. I do have some other priorities as well. If I am correct I am using this in production somewhere already ... |
|
@AndreSteenbergen all good - I added some myself. Had an urgent need for this feature and figured I could get it into a 1.3.13 release before I pull all of the v1.4 stuff into the |
|
@AndreSteenbergen good news is that all of your code worked perfectly - threw a Property-based test at the queue structure itself to verify it and some tests on the mailbox too. All worked as expected. |
I ain't installing anything 1.3.13 in production... |
LOL :p - maybe I'll do what the airlines do and skip over having seat 13 and go straight to 14 instead :p |
|
You can surely publish 1.3.13, just don't publish it on Friday the 13th ;) |
* Added an UnboundStablePriorityMailbox, sending messages according to priority. Messages with the same priority will be send using the same order as they appear. akkadotnet#2652 is the related issue. * added PropertyTest for StableListPriorityQueue * forgot to add spec * verified that the UnboundedStablePriorityMailbox can be loaded and used * validate4d that UnboundedStablePriorityMailbox supports stashing * added API approval for core
Added an UnboundStablePriorityMailbox, sending messages according to priority. Messages with the same priority will be send using the same order as they appear. #2652 is the related issue.