[WIP] CoordinatedShutdown and ClusterDaemon fixes #3497
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Jun 8, 2018
| @@ -534,7 +534,7 @@ internal static void InitPhaseActorSystemTerminate(ActorSystem system, Config co | |||
| // We must spawn a separate Task to not block current thread, | |||
| // since that would have blocked the shutdown of the ActorSystem. | |||
| var timeout = coord.Timeout(PhaseActorSystemTerminate); | |||
| return Task.Run(() => | |||
| Task.Run(() => | |||
There was a problem hiding this comment.
Not supposed to return a Task here. Supposed to just let the process run asynchronously and invoke once the ActorSystem has finished terminating.
Aaronontheweb
commented
Jun 8, 2018
| { | ||
| // forces downstream error propagation if recover is disabled | ||
| var force = tr.Result; |
There was a problem hiding this comment.
Let the task run asynchronously, but still propagate failures downstream.
|
@Horusiath thanks for the suggestions; was able to reproduce the issue with #3413 - I think I can TDD it from here. |
e7439de to
d8d80de
Compare
Merged
|
Looks like it's the reproduction spec for this that's failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Designed to reproduce and fix #3413