Akka.Streams: add PreMaterialize support for Sources #3476
Conversation
docs/articles/streams/basics.md
Outdated
|
|
||
| ### Source pre-materialization | ||
| There are situations in which you require a `Source` materialized value **before** the `Source` gets hooked up to the rest of the graph. | ||
| +This is particularly useful in the case of "materialized value powered" `Source`s, like `Source.Queue`, `Source.ActorRef` or `Source.Maybe`. |
There was a problem hiding this comment.
Whoops, good catch.
docs/articles/streams/basics.md
Outdated
| Tuple<TaskCompletionSource<int>, Source<int>> materialized = matValPoweredSource.PreMaterialize(Sys.Materializer()); | ||
| var tcs = materialized.Item1; | ||
| var nextSource = materialized.Item2; | ||
| ``` |
There was a problem hiding this comment.
It’s probably fine to include this code directly in the .md since all the other code examples are here as well, but in general haven’t we agreed on using the document projects for code examples ?!
There was a problem hiding this comment.
@marcpiechura yeah, we try to do that for the most part going forward but we don't have anything organized for that in Akka.Streams itself at the moment. I'd personally prefer to do something that is compile-time checked and there referred to via DocFx's source code embedding, akin to https://github.com/akka/akka/pull/24497/files#diff-96bb38a1bfc1933567a890af8f3d0263
But starting the infrastructure for that is a bigger project than adding just this one feature. So question for you is: start building the infrastructure now or throw yet one more thing on the future technical debt pile for later? I'm opted for the latter (obviously) but, if there's buy-in from other folks to go down the route of doing something similar to what the JVM does then I'd be all for it.
There was a problem hiding this comment.
Welp, I was wrong about this - we do have support for this built into the project already. Just uploaded some changes which incorporate it.
|
@marcpiechura I think I addressed all of your comments in the newest commit. |
|
@Aaronontheweb there is still the ++ in the readme ;-) |
|
@marcpiechura damn, thought I got it - just fixed... again :p |
Port of akka/akka#24497