Skip to content

Introducing BenchmarkDotNet benchmarks #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 31, 2018

Conversation

Horusiath
Copy link
Contributor

This PR introduces new benchmarking project using BenchmarkDotNet. So far following cases have been included:

  • Akka.IO.ByteString benchmarks including byte string creation, concatenation and slicing.
  • Consistent hash benchmarks where I'm comparing our Murmur implementation with Jenkins hash used in Orleans.
  • Akka.Util.FastLazy value materialization comparison with native System.Lazy.
  • Type.TypeQualifiedName() compared to Type.FullName.
  • ActorPath and Address parsing, concat, comparison and equivalence benchmarks.

There are also two monitored benchmarks, that shouldn't count as microbenchmarks, but BenchmarkDotNet can do them too:

  • Spawn actor measurements.
  • Local-only 1-to-1 actor ping pong (I'm measuring only 2 communicating actors here).

Those 2 checks can potentially make PingPong.csproj and SpawnBenchmark.csproj obsolete.

I'm hoping to introduce more benchmarks in future PRs.

@Aaronontheweb
Copy link
Member

Where does the output from these get stored?

@Horusiath
Copy link
Contributor Author

Default location is /bin/Release/netcoreapp2.0/BenchmarkDotNet.Artifacts/results

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Aaronontheweb
Copy link
Member

@Horusiath got a warning back that the API specs had failed for Streams and Core. No idea why. Rebased on the latest dev - did you make any changes that would have affected those? I couldn't see any during my review, but I was mostly looking at the project metadata itself.

@Horusiath
Copy link
Contributor Author

Beside adding [assembly:InternalsVisibleTo("Akka.Benchmarks")] nothing has been changed in any other project.

@Aaronontheweb
Copy link
Member

We'll see what it says on this run.

@Horusiath Horusiath force-pushed the benchmark-dot-net branch from 7e39daf to 0fd5ebf Compare May 30, 2018 17:29
@@ -1,4 +1,5 @@
[assembly: System.Runtime.CompilerServices.InternalsVisibleToAttribute("Akka.Cluster")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see.. It was the internals stuff

@Aaronontheweb Aaronontheweb merged commit 1b1146b into akkadotnet:dev May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants