upgraded to DotNetty v0.4.8 #3439
Conversation
|
Looks like the behavior is different upon shutdown in .NET Core for DotNetty v0.4.8 - going to need to adjust the specs here. I know they've changed some stuff with trying to prevent resource leaks inside DotNetty itself in this patch and it looks like that's what is showing up in the specs here. |
f560d40 to
909c9b4
Compare
| @@ -209,17 +209,18 @@ public TcpTransport(ActorSystem system, Config config) : base(system, config) | |||
| var handler = (TcpClientHandler)associate.Pipeline.Last(); | |||
| return await handler.StatusFuture.ConfigureAwait(false); | |||
| } | |||
| catch (ConnectException c) | |||
There was a problem hiding this comment.
Fixed the failing test - simple change, really. Issue just was that DotNetty v0.4.8 doesn't necessarily throw an AggregateException with a ConnectException anymore; we'll just get the ConnectException itself in the catch block. So, modified those methods to handle that case explicitly.
|
This is ready to go - once it's merged in I'm going to run a long-running "soak test" for about 48 hours on another machine to see if we have any problems with resource leaks. Reports I've received from end-users running custom builds indicate that this isn't an issue, but I'd like to be sure. If we run into trouble with v0.4.8 I'll institute a rollback before we push Akka.NET v1.3.8. |
close #3437