Skip to content

Ask deadlock - proof of concept #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 7, 2018
Merged

Ask deadlock - proof of concept #3257

merged 2 commits into from
Jan 7, 2018

Conversation

maxcherednik
Copy link
Contributor

@maxcherednik maxcherednik commented Jan 6, 2018 •
edited
Loading

Deadlock comes as an edge case from ContinueWith, await and TaskCompletionSource.
One TaskCompletionSource was covered, but there is another one in CastTask

@Horusiath Horusiath self-requested a review January 7, 2018 17:13
Horusiath
Horusiath approved these changes Jan 7, 2018
View reviewed changes
Copy link
Contributor

@Horusiath Horusiath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good. Let me know when it's no longer WIP.

@maxcherednik maxcherednik changed the title [WIP] Ask deadlock - proof of concept Ask deadlock - proof of concept Jan 7, 2018
@maxcherednik
Copy link
Contributor Author

maxcherednik commented Jan 7, 2018 •
edited
Loading

@Horusiath Go ahead. The rest I will be doing on the other PR

@Horusiath Horusiath merged commit 8f455bf into akkadotnet:dev Jan 7, 2018
@maxcherednik maxcherednik deleted the askDeadlock branch January 14, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Horusiath Horusiath Horusiath approved these changes

Assignees
No one assigned
Labels
akka-actor reviewed positively WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxcherednik @Horusiath @Aaronontheweb