Added human-friendly error for failed MNTK discovery #3198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the not so obvious requirements for writing MultiNode TestKit test classes is that, this class must not only inherit from
MultiNodeSpec
, but somewhere in its inheritance chain it also must specify a constructor, which first parameter is a class inheriting fromMultiNodeConfig
.Up to this point, if this requirement was not fulfilled, we simply crashed with NRE - since we tried to go down the test class inheritance chain until we reached System.Object, which BaseType is null.
This PR replaces recursive check with loop. When the loop ends and no correct config class was found, we throw a meaningful message informing user what has gone wrong. Example: