When a task is cancelled signal and when timed out raise exception #3182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR changes a timeout contract a little (from |
|
Changes are going to break a whole bunch of other people's code who depend on the current exceptions being thrown as-is. |
| @@ -141,6 +141,23 @@ public void Can_Ask_actor_inside_receive_loop() | |||
| waitActor.Tell("ask"); | |||
| ExpectMsg("bar"); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void Cancelled_ask_with_timeout_should_raise_timeout_exception() | |||
There was a problem hiding this comment.
xunit supports async await. Can we please use it? This will help to avoid wrapping/unwrapping exceptions.
|
@Horusiath Why do we need to change the contract of the method? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3162
I was genuinely spooked that we didn't get a TimeoutException on timeouts and TaskCanceledException on cancellations.
I appreciate this is a bit of a fundamental change, I think it's an improvement, but my understanding probably isn't good enough to see possible repercussions.