Fix xunit publish #3174
Merged
Fix xunit publish #3174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Oct 24, 2017
| ++ "src/**/Akka.Serialization.Hyperion.csproj" | ||
| ++ "src/**/Akka.Serialization.TestKit.csproj" | ||
| ++ "src/**/Akka.Remote.Transport.Helios.csproj" | ||
| let projects = !! "src/**/*.csproj" |
There was a problem hiding this comment.
Rewrote this to work via convention.
Aaronontheweb
commented
Oct 24, 2017
|
|
||
| <PropertyGroup> | ||
| <!-- WORKAROUND: for some reason starting at Akka.NET 1.3.2 this package was determined as "unpackable" by default via DOTNET CLI --> | ||
| <IsPackable>true</IsPackable> |
There was a problem hiding this comment.
I have no idea why the .NET Core SDK suddenly started skipping these packages. Found out that's what was occurring when I ran dotnet pack -v diag on the individual Akka.TestKit.XUnit projects
There was a problem hiding this comment.
Yep, IsPackable is false by default for test projects, so you have to opt-in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3173