disabled Hyperion warning #3165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had this warning in the codebase for a year and we've not set a timeframe for the Hyperion switch.
Urging users to switch from something stable (JSON.NET) to something that is still in beta (Hyperion) isn't the right call at the moment considering that we're not directing a lot of resources into Hyperion right now due to other priorities (i.e. such as integrating with all of the new standard APIs for configuration, dependency injection, Unity3D, Xamarin support, etc... - stuff that wasn't on anyone's radar a year ago.)
Beyond that the most urgent issues solved by Hyperion, related to Cluster.Sharding, were solved via dedicated Protobuf serializers in 1.3. The ultimate plan is still the same: to switch from JSON.NET to Hyperion in the 1.5 release. But the timeframe for that is indeterminate and realistically we're not focused on that right now. So let's get rid of the code smell and keep people on something that works.