Streams XML Docs fixes #3136
Merged
Streams XML Docs fixes #3136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvaluyskiy
commented
Sep 30, 2017
| @@ -58,11 +59,14 @@ | |||
| "_site/**" | |||
| ] | |||
| }], | |||
| "xref": [ | |||
| "../tools/msdn.4.5.2/content/msdn.4.5.2.zip" | |||
There was a problem hiding this comment.
All references to the default types will refer to MSDN
alexvaluyskiy
commented
Sep 30, 2017
| @@ -15,6 +15,7 @@ | |||
| "src": "../src" | |||
| }], | |||
| "dest": "api", | |||
| "filter": "filterConfig.yml", | |||
There was a problem hiding this comment.
All APIs which marked with InternalApiAttribute will be removed from API referenced
alexvaluyskiy
commented
Sep 30, 2017
| /// or will be failed when the stage faces an internal failure or the the <see cref="Fail"/> method is invoked. | ||
| /// </summary> | ||
| /// <returns>Task</returns> | ||
| new Task WatchCompletionAsync(); |
There was a problem hiding this comment.
ISourceQueueWithComplete.WatchCompletionAsync has different semantic that simple ISourceQueue.WatchCompletionAsync. What is the best way to highlight it?
There was a problem hiding this comment.
Seems like a @Silv3rcircl3 question
| let docsExamplesSolution = "./docs/examples/DocsExamples.sln" | ||
| DotNetCli.Restore (fun p -> { p with Project = docsExamplesSolution }) | ||
| DotNetCli.Build (fun p -> { p with Project = docsExamplesSolution; Configuration = configuration }) | ||
|
|
||
| let docsPath = "./docs" | ||
| // install MSDN references |
There was a problem hiding this comment.
Nice! so this will allow some of the refs we use to point back to the MSDN docs from our own site going forward?
de49b75 to
d71f114
Compare
|
@alexvaluyskiy is this ready to go? |
|
@Aaronontheweb yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.