Skip to content

Fix Ask deadlock #2 #3120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 26, 2017
Merged

Fix Ask deadlock #2 #3120

merged 4 commits into from
Sep 26, 2017

Conversation

0x53A
Copy link
Contributor

@0x53A 0x53A commented Sep 22, 2017

@0x53A 0x53A mentioned this pull request Sep 22, 2017
Closed
Aaronontheweb
Aaronontheweb reviewed Sep 22, 2017
View reviewed changes
src/core/Akka/Actor/Futures.cs Outdated
@@ -128,10 +128,18 @@ internal static IActorRefProvider ResolveProvider(ICanTell self)
return null;
}

private const int RunContinuationsAsynchronously = 64;
private static bool isRunContinuationsAsynchronouslyAvailable = Enum.IsDefined(typeof(TaskCreationOptions), RunContinuationsAsynchronously);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0x53A mark as readonly

@Aaronontheweb
Copy link
Member

@0x53A missing a public API approval: http://getakka.net/community/public-api-changes.html

@Aaronontheweb
Copy link
Member

@0x53A and the other PR we re-opened, should still look at merging that in addition to this one, correct?

@0x53A
Copy link
Contributor Author

0x53A commented Sep 22, 2017 •
edited
Loading

This one supersedes the other one - you can decide which one to take (this branch is even based on the other one, but I would rebase it before you merge)

Edit: rebased

@0x53A
fix deadlock after .Ask
031273c 
create TaskCompletionSource with RunContinuationsAsynchronously; otherwise wrap .TrySetResult in Task.Run
@0x53A 0x53A force-pushed the ask-RunContinuationsAsynchronously branch from f15f6dd to 031273c Compare September 22, 2017 21:40
@0x53A 0x53A closed this Sep 23, 2017
@0x53A 0x53A reopened this Sep 23, 2017
@Aaronontheweb Aaronontheweb merged commit baf65ea into akkadotnet:dev Sep 26, 2017
@Aaronontheweb Aaronontheweb mentioned this pull request Oct 11, 2017
Closed
@Aaronontheweb Aaronontheweb mentioned this pull request Oct 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x53A @Aaronontheweb