Skip to content

Human-friendly streams assertions #3126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2017
Merged

Human-friendly streams assertions #3126

merged 1 commit into from
Sep 26, 2017

Conversation

Horusiath
Copy link
Contributor

@Horusiath Horusiath commented Sep 26, 2017 •
edited
Loading

This PR fixes the problem of unreadable assert messages in Akka.Streams TestSubscriber.

*Before

Got a message of the expected type <Akka.Streams.TestKit.TestSubscriber+OnNext1[[System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]]>. Also expected the predicate to return true but the message {TestSubscriber.OnNext(a)} of type <Akka.Streams.TestKit.TestSubscriber+OnNext1[[System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]]> did not match

After

Expected 'a' but got 'c'

@marcpiechura marcpiechura merged commit 1a3ea81 into akkadotnet:dev Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvaluyskiy alexvaluyskiy Awaiting requested review from alexvaluyskiy

Assignees
No one assigned
Labels
akka-streams tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Horusiath @Aaronontheweb @marcpiechura