Updated Dynamic Streams article #3107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcpiechura
suggested changes
Sep 17, 2017
docs/articles/streams/basics.md
Outdated
| > Akka Streams implements these concepts as ``Source``, ``Flow`` (referred to as ``Processor`` in Reactive Streams) | ||
| and ``Sink`` without exposing the Reactive Streams interfaces directly. | ||
| > If you need to integrate with other Reactive Stream libraries read [Integrating with Reactive Streams](integration.md#integrating-with-reactive-streams). | ||
| and ``Sink`` without exposing the Reactive Streams interfaces directly. > If you need to integrate with other Reactive Stream libraries read [Integrating with Reactive Streams](integration.md#integrating-with-reactive-streams). |
There was a problem hiding this comment.
Doesn't need this link to be updated too? Also maybe put a line break for the quote
docs/articles/streams/basics.md
Outdated
| @@ -351,7 +337,7 @@ IRunnableGraph<TaskCompletionSource<int>> r1 = source.Via(flow).To(sink); | |||
| IRunnableGraph<ICancelable> r2 = source.ViaMaterialized(flow, Keep.Right).To(sink); | |||
| IRunnableGraph<Task<int>> r3 = source.Via(flow).ToMaterialized(sink, Keep.Right); | |||
|
|
|||
| //Using runWith will always give the materialized values of the stages added | |||
| //Using RunWith will always give the materialized values of the stages added | |||
There was a problem hiding this comment.
Either add () to RunWith or remove them from the next RunWith
| @@ -60,16 +69,16 @@ Akka Streams must enable a library to express any stream processing utility in t | |||
| > A source that emits a stream of streams is still just a normal Source, the kind of elements that are produced does not play a role in the static stream topology that is being expressed. | |||
|
|
|||
| ## The difference between Error and Failure | |||
| The starting point for this discussion is the definition given by the [Reactive Manifesto](http://www.reactivemanifesto.org/glossary#Failure). Translated to streams this means that an error is accessible within the stream as a normal data element, while a failure means that the stream itself has failed and is collapsing. In concrete terms, on the Reactive Streams interface level data elements (including errors) are signalled via `onNext` while failures raise the `onError` signal. | |||
| The starting point for this discussion is the definition given by the [Reactive Manifesto](http://www.reactivemanifesto.org/glossary#Failure). Translated to streams this means that an error is accessible within the stream as a normal data element, while a failure means that the stream itself has failed and is collapsing. In concrete terms, on the Reactive Streams interface level data elements (including errors) are signalled via `OnNext` while failures raise the `onError` signal. | |||
There was a problem hiding this comment.
Make onError also uppercase
marcpiechura
approved these changes
Sep 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.