Fixed Sharding serialization bug #3094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvaluyskiy
commented
Sep 12, 2017
| @@ -149,12 +149,9 @@ public sealed override object FromBinary(byte[] bytes, Type type) | |||
| /// <summary> | |||
| /// INTERNAL API. | |||
| /// </summary> | |||
| internal static class SerializerIdentifierHelper | |||
| public static class SerializerIdentifierHelper | |||
There was a problem hiding this comment.
I made this class as internal by accident. It should be public
|
@alexvaluyskiy I don't get it, where is the actual fix for the issue in this PR? edit: in other words, I looked through the files and couldn't find it. Could you call it out with a comment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #3087
Also converted Sharding example to .NET Core 1.1