Skip to content

Conversation

alexvaluyskiy
Copy link
Contributor

@alexvaluyskiy alexvaluyskiy commented Sep 3, 2017

  • .NET Core SDK from 1.0.4 to 2.0.0
  • FAKE from 4.61.2 to 4.63.0
  • Nuget from 4.1.0 to 4.3.0
  • Google.Protobuf.Tools from 3.2.0 to 3.4.0
  • Microsoft.NET.Test.Sdk from 15.0.0 to 15.3.0
  • Removed Optimized=false for .NetStandard1.6 Release netstandard1.6 build is Optimize false #3088

@Danthar
Copy link
Member

Danthar commented Sep 5, 2017

This is not an official bump to netstandard 2.0 right ?

@joshgarnett
Copy link
Contributor

joshgarnett commented Sep 5, 2017

Be careful with the Google.Protobuf upgrades, they made some significant changes from 3.0 -> 3.3 around code generation of enums, which made for a pretty painful upgrade. Hopefully the 3.2 -> 3.4 is less of a headache for c#.

@alexvaluyskiy
Copy link
Contributor Author

alexvaluyskiy commented Sep 8, 2017

@joshgarnett could you show an example, please? I did not see any breaking changes in Google.Protobuf/Tools

@Danthar No, it is not related with netstandard2.0. I'm just trying to update the tooling

@joshgarnett
Copy link
Contributor

From 3.0 -> 3.2 (?) the C# code generation changed enums from upper snake case to upper camel case. ex: FOO_BAR to FooBar. It create a big headache of a refactor for me on my project. I don't know of any similar changes for 3.2 -> 3.4. I mainly just wanted to call it out as something to watch out for.

@Aaronontheweb
Copy link
Member

@joshgarnett @alexvaluyskiy why include any Protobuf upgrades right now? Just drop them?

@Aaronontheweb
Copy link
Member

Although, I guess it should be ok since all of that stuff is internal and this doesn't affect wire compatibility, right?

@alexvaluyskiy alexvaluyskiy changed the title [WIP] Update to NetCoreSdk 2.0.0 Update to NetCoreSdk 2.0.0 Sep 12, 2017
@Aaronontheweb Aaronontheweb merged commit bc3fdb8 into akkadotnet:dev Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants