Updated UdpConnection to match TcpConnection send semantics #3053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Horusiath oh snap, I was in the middle of implementing this myself. I'll review yours instead |
Aaronontheweb
requested changes
Aug 31, 2017
Aaronontheweb
approved these changes
Sep 1, 2017
| @@ -34,7 +34,7 @@ protected override bool Receive(object message) | |||
| { | |||
| case UdpConnected.Connect connect: | |||
| { | |||
| var commander = Sender; | |||
| var commander = Sender; // NOTE: Aaronontheweb (9/1/2017) this should probably be the Handler... | |||
There was a problem hiding this comment.
This seems like a bug to me; the .Handler property on the Connect message is never actually used... But changing it now would be a breaking change for anyone who has ever used this feature. Decided to just take note of it and punt on it until a later time in the interests of fixing sending behavior first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide the same send semantics over UDP connection, as the one used by TcpConnection, that were introduced by @Aaronontheweb in #3023