Protobuf serialization support for FSM types #3047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To bring the Akka.Persistence module more in line with the JVM Akka implementation protobuf serialization of PersistentFSMSnapshot and StateChangeEvent classes. As PersistentFSMSnapshot uses generics, reflection is needed to properly serialize and deserialize the class.
|
@joshgarnett missing API approvals |
Aaronontheweb
requested changes
Aug 29, 2017
| @@ -173,7 +174,7 @@ public interface IFsmState | |||
| /// Persisted on state change | |||
| /// TODO: should implement IMessage | |||
| /// </summary> | |||
| public class StateChangeEvent | |||
| public class StateChangeEvent : IMessage | |||
Added a few additional tests around the FSM serialization.
Aaronontheweb
approved these changes
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To bring the Akka.Persistence module more in line with the JVM Akka implementation protobuf serialization of PersistentFSMSnapshot and StateChangeEvent classes. As PersistentFSMSnapshot uses generics, reflection is needed to properly serialize and deserialize the class.