Improving Support for OSX & Rider #3022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joshgarnett
commented
Aug 24, 2017
- Rider/OSX appears to be less forgiving around the csproj format and requires that the nuget dependencies use Version and not version.
- Updated the build.sh script to only install dotnet once and also to pull down protoc from nuget.
- The FAKE build has been updated to support building the Protobuf target on OSX & Linux
* Rider/OSX appears to be less forgiving around the csproj format and requires that the nuget dependencies uses Version and not version. * Updated the build.sh script to only install dotnet once and also to pull down protoc from nuget. * The FAKE build has been updated to support building the Protobuf target on OSX & Linux
|
Looks good 😄 |
|
I'm not sure what the issue is here exactly, but the Mono test runner is hitting the deck when it starts scanning for test assemblies to run... What could be causing that? |
|
It doesn't seem like the failure was related to the change from what I can tell. I'll look at getting the branch caught up to dev. |
Closed
Danthar
reviewed
Aug 24, 2017
| @@ -42,17 +44,19 @@ fi | |||
| # INSTALL .NET CORE CLI | |||
| ########################################################################### | |||
|
|
|||
| echo "Installing .NET CLI..." | |||
There was a problem hiding this comment.
This change for not installing .NET CLI is whats causing the issue here. Revert this section and it should solve your problem
build.sh
Outdated
| # INSTALL PROTOC | ||
| ########################################################################### | ||
|
|
||
| unameOut="$(uname -s)" |
…t variables properly if dotnet was already installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.