Protobuf Serialization for Akka.Persistence.IMessage #3029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joshgarnett
commented
Aug 25, 2017
- Ported over MessageSerializer & SnapshotSerializer from JVM Akka
- Custom serializers are now being used as expected. Previously, as is evident by the unit test changes, custom serializers were not being used when serializing Akka.Persistence.IMessage.
- LocalSnapshotStore automatically picks up the new serializer and should work better with protobuf based snapshots
* Ported over MessageSerializer & SnapshotSerializer from JVM Akka * Custom serializers are now being used as expected. Previously, as is evident by the unit test changes, custom serializers were not being used when serializing Akka.Persistence.IMessage. * LocalSnapshotStore automatically picks up the new serializer and should work better with protobuf based snapshots
Danthar
reviewed
Aug 25, 2017
|
|
||
| private PersistentPayload GetPersistentPayload(object obj) | ||
| { | ||
| Serializer serializer = system.Serialization.FindSerializerFor(obj); |
There was a problem hiding this comment.
Needs DefaultSerializer persistence setting support.
There was a problem hiding this comment.
But i dont consider it a blocking issue. We can fix it later. Its not a thing that will break any existing stuff
There was a problem hiding this comment.
As we talked about in chat, the current dev branch does not support specifying the default serializer for persistence serialization, it just uses whatever has been defined for the objects in the serialization-bindings.
Currently the dev branch doesn't actually support custom serializers at all for the payload within the IPersistentRepresentation, this was fixed and is reflected in the unit test changes.
This was referenced Aug 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.