Skip to content

Conversation

heynickc
Copy link
Contributor

@heynickc heynickc commented Aug 8, 2017

Builds Akka.FSharp and Akka.FSharp.Tests using the build script, but does not add it to the .sln because VS 2017 15.2 doesn't support the new format of MSBuild 15 projects for .fsproj per this issue: dotnet/fsharp#2316

Note: 2 specs fail and I'm having difficulty grokking why

    Akka.FSharp.Tests.InfrastructureTests.IActorRef should be possible to use as a Key [FAIL]
      System.ArgumentException : Expression of type 'Microsoft.FSharp.Core.FSharpFunc`2[Microsoft.FSharp.Core.Unit,Akka.FSharp.Actors+FunActor`2[System.Object,System.Object]]' cannot be used for return type 'Akka.
FSharp.Actors+FunActor`2[System.Object,System.Object]'
      Stack Trace:
           at System.Linq.Expressions.Expression.ValidateLambdaArgs(Type delegateType, Expression& body, ReadOnlyCollection`1 parameters)
           at System.Linq.Expressions.Expression.Lambda(Type delegateType, Expression body, String name, Boolean tailCall, IEnumerable`1 parameters)
           at System.Linq.Expressions.Expression.Lambda(Type delegateType, Expression body, IEnumerable`1 parameters)
           at Microsoft.FSharp.Linq.RuntimeHelpers.LeafExpressionConverter.ConvExprToLinqInContext(ConvEnv env, FSharpExpr inp)
           at Microsoft.FSharp.Linq.RuntimeHelpers.LeafExpressionConverter.QuotationToLambdaExpression[T](FSharpExpr`1 e)
           at Akka.FSharp.Spawn.spawnOpt[Message,Returned](IActorRefFactory actorFactory, String name, FSharpFunc`2 f, FSharpList`1 options)
           at Akka.FSharp.Tests.InfrastructureTests.IActorRef should be possible to use as a Key()
    Akka.FSharp.Tests.ApiTests.actor that accepts _ will receive string message [FAIL]
      System.ArgumentException : Expression of type 'Microsoft.FSharp.Core.FSharpFunc`2[Microsoft.FSharp.Core.Unit,Akka.FSharp.Actors+FunActor`2[System.Object,System.Object]]' cannot be used for return type 'Akka.
FSharp.Actors+FunActor`2[System.Object,System.Object]'
      Stack Trace:
           at System.Linq.Expressions.Expression.ValidateLambdaArgs(Type delegateType, Expression& body, ReadOnlyCollection`1 parameters)
           at System.Linq.Expressions.Expression.Lambda(Type delegateType, Expression body, String name, Boolean tailCall, IEnumerable`1 parameters)
           at System.Linq.Expressions.Expression.Lambda(Type delegateType, Expression body, IEnumerable`1 parameters)
           at Microsoft.FSharp.Linq.RuntimeHelpers.LeafExpressionConverter.ConvExprToLinqInContext(ConvEnv env, FSharpExpr inp)
           at Microsoft.FSharp.Linq.RuntimeHelpers.LeafExpressionConverter.QuotationToLambdaExpression[T](FSharpExpr`1 e)
           at Akka.FSharp.Spawn.spawnOpt[Message,Returned](IActorRefFactory actorFactory, String name, FSharpFunc`2 f, FSharpList`1 options)
           at Akka.FSharp.Tests.ApiTests.actor that accepts _ will receive string message()

I was unable to resolve these so WIP until I can get a little help.

@Horusiath
Copy link
Contributor

Could we comment failing tests? I can work them out after merging this PR.

@alexvaluyskiy
Copy link
Contributor

@Horusiath Nick is on vacation. The better idea is to take his code and make an another pull request

@Danthar
Copy link
Member

Danthar commented Apr 18, 2018

Superseeded by other work

@Danthar Danthar closed this Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants