Protobuf serializer for Exceptions #2925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvaluyskiy
commented
Aug 3, 2017
| Actor = (IActorRef)info.GetValue("Actor", typeof(IActorRef)); | ||
| } | ||
|
|
||
| public override void GetObjectData(SerializationInfo info, StreamingContext context) |
There was a problem hiding this comment.
It is mandatory method for exceptions, which contains custom properties
|
@alexvaluyskiy I'm getting compilation failures here since I rebased |
50a761e to
a56963a
Compare
alexvaluyskiy
commented
Aug 5, 2017
| @@ -302,7 +302,7 @@ public void RemoteRouter_must_let_remote_deployment_be_overridden_by_remote_conf | |||
| masterSystem.Stop(router); | |||
| } | |||
|
|
|||
| [Fact(Skip = "Serialization of custom deciders is currently not supported")] | |||
| [Fact] | |||
| public void RemoteRouter_must_set_supplied_SupervisorStrategy() | |||
There was a problem hiding this comment.
This test is working now
alexvaluyskiy
commented
Aug 5, 2017
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="ActorInitializationException"/> class. | ||
| /// </summary> | ||
| protected ActorInitializationException() | ||
| public ActorInitializationException() |
There was a problem hiding this comment.
public constructor is mandatory for NetCore support (due to limitations of our serializer)
|
@heynickc MNTK tests don't want to pass. I don't know why |
|
@alexvaluyskiy looks like @Arkatufus has fixed it here #2936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.